Skip to content

use QUIC_ADDRESS_FAMILY enum for assigning socket family - #53673

Merged
wfurt merged 1 commit into
dotnet:mainfrom
wfurt:ipv6_53495
Jun 3, 2021
Merged

use QUIC_ADDRESS_FAMILY enum for assigning socket family#53673
wfurt merged 1 commit into
dotnet:mainfrom
wfurt:ipv6_53495

Conversation

@wfurt

@wfurt wfurt commented Jun 3, 2021

Copy link
Copy Markdown
Member

Use QUIC_ADDRESS_FAMILY to make it clear the values are MsQUIC specific and not OS/Platform.
There is no functional change.

fixes #53495
cc: @ThadHouse

@wfurt
wfurt requested a review from a team June 3, 2021 12:44
@wfurt wfurt self-assigned this Jun 3, 2021
@ghost

ghost commented Jun 3, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Use QUIC_ADDRESS_FAMILY to make it clear the values are MsQUIC specific and not OS/Platform.
There is no functional change.

fixes #53495
cc: @ThadHouse

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

@ManickaP ManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@wfurt
wfurt merged commit 01a8f49 into dotnet:main Jun 3, 2021
@wfurt
wfurt deleted the ipv6_53495 branch June 3, 2021 16:54
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QUIC: IPv6 constant looks suspicious in native helper

6 participants